maskit commented on code in PR #9869:
URL: https://github.com/apache/trafficserver/pull/9869#discussion_r1232896275


##########
proxy/http/HttpSM.h:
##########
@@ -569,9 +545,7 @@ class HttpSM : public Continuation, public 
PluginUserArgs<TS_USER_ARGS_TXN>
 
   HttpVCTable vc_table;
 
-  IOBufferReader *ua_raw_buffer_reader = nullptr;
-
-  HttpVCTableEntry *ua_entry     = nullptr;
+  HttpUserAgent _ua{};

Review Comment:
   It looks like we could do a similar thing for `server_entry` and 
`server_txn`. What would it be called? `HttpServer`? It would be nice if the 
two had a same prefix or suffix in their names to indicate they are basically 
the same thing but one for client side and one for server side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to