maskit commented on code in PR #9869:
URL: https://github.com/apache/trafficserver/pull/9869#discussion_r1235781795
##########
proxy/http/HttpSM.h:
##########
@@ -569,9 +545,7 @@ class HttpSM : public Continuation, public
PluginUserArgs<TS_USER_ARGS_TXN>
HttpVCTable vc_table;
- IOBufferReader *ua_raw_buffer_reader = nullptr;
-
- HttpVCTableEntry *ua_entry = nullptr;
+ HttpUserAgent _ua{};
Review Comment:
I'm not requesting the change for server on this PR, but I want to know what
you are going to do.
If we're going to have `HttpServer` and it has `m_entry`,
`m_raw_buffer_reader` and `m_txn`, I'd make a base class and probably name it
`HttpPeer` or something, and I don't think the base class is too much addition.
But that could be different from what you have on your mind. I couldn't read
your plan from this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
