JosiahWI commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1240203139
##########
iocore/net/TLSSNISupport.cc:
##########
@@ -64,8 +67,12 @@ TLSSNISupport::perform_sni_action()
}
SNIConfig::scoped_config params;
- if (const auto &actions = params->get({servername,
std::strlen(servername)}); !actions.first) {
- Debug("ssl_sni", "%s not available in the map", servername);
+ // should always work in this context of SSL action callbacks
+ SSLNetVConnection *ssl_vc{dynamic_cast<SSLNetVConnection *>(this)};
Review Comment:
Do you have an example of where we need to use SNI and do not want the
`NetVConnection` to have a local port number? If that's because there is none,
that implies we need to re-evaluate this whole idea of filtering by port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
