maskit commented on code in PR #9869:
URL: https://github.com/apache/trafficserver/pull/9869#discussion_r1242441821
##########
proxy/http/HttpSM.h:
##########
@@ -679,10 +622,58 @@ HttpTransact::State::state_machine_id() const
return state_machine->sm_id;
}
+inline bool
+HttpSM::get_client_tcp_reused() const
+{
+ return _ua.get_client_tcp_reused();
+}
+
+inline bool
+HttpSM::get_client_ssl_reused() const
+{
+ return _ua.get_client_ssl_reused();
+}
+
+inline bool
+HttpSM::get_client_connection_is_ssl() const
+{
+ return _ua.get_client_connection_is_ssl();
+}
+
+inline char const *
+HttpSM::get_client_protocol() const
+{
+ return _ua.get_client_protocol();
+}
+
+inline char const *
+HttpSM::get_client_sec_protocol() const
+{
+ return _ua.get_client_sec_protocol();
+}
+
+inline char const *
+HttpSM::get_client_cipher_suite() const
+{
+ return _ua.get_client_cipher_suite();
+}
+
+inline char const *
+HttpSM::get_client_curve() const
+{
+ return _ua.get_client_curve();
+}
+
+inline int
+HttpSM::get_client_alpn_id() const
+{
+ return _ua.get_client_alpn_id();
+}
+
Review Comment:
So, we have to add a function to `HttpSM` when we add a function to
`HttpUserAgent`? Is it a bad idea to have `HttpSM::get_client` or
`HttpSM::get_useragent` so we don't have to have these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
