ywkaras commented on code in PR #9875: URL: https://github.com/apache/trafficserver/pull/9875#discussion_r1244239183
########## include/wccp/Wccp.h: ########## @@ -121,7 +124,7 @@ class ServiceGroup : public ServiceConstants static uint8_t const RESERVED = 50; /// Number of ports in component (defined by protocol). - static size_t const N_PORTS = 8; + static constexpr size_t const N_PORTS = 8; Review Comment: > The effect is you don't have to define this in a cpp file. If that were true, we'd have gotten link failures prior to this change. You must be thinking of Objective-C or Swift or something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
