SolidWallOfCode commented on code in PR #9875: URL: https://github.com/apache/trafficserver/pull/9875#discussion_r1267296361
########## include/wccp/Wccp.h: ########## @@ -121,7 +124,7 @@ class ServiceGroup : public ServiceConstants static uint8_t const RESERVED = 50; /// Number of ports in component (defined by protocol). - static size_t const N_PORTS = 8; + static constexpr size_t const N_PORTS = 8; Review Comment: I'm not going to worry about this because all of WCCP is going to be deprecated and removed. I think I added `constexpr` because I was blindly adding it to various this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
