cmcfarlen commented on code in PR #10283:
URL: https://github.com/apache/trafficserver/pull/10283#discussion_r1308025850
##########
CMakeLists.txt:
##########
@@ -307,6 +307,9 @@ endif()
# Catch2 for tests
set(CATCH_INCLUDE_DIR ${CMAKE_SOURCE_DIR}/lib/catch2)
+add_library(catch::catch INTERFACE IMPORTED)
+target_include_directories(catch::catch INTERFACE ${CMAKE_SOURCE_DIR}/include
${CATCH_INCLUDE_DIR})
Review Comment:
We vendor the catch header file so we don't use the find package. I just
wanted the prettier way of getting the include :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
