JosiahWI commented on code in PR #10283:
URL: https://github.com/apache/trafficserver/pull/10283#discussion_r1309365855
##########
proxy/hdrs/CMakeLists.txt:
##########
@@ -46,3 +46,26 @@ target_link_libraries(hdrs
PRIVATE
ts::inkevent
)
+
+add_executable(test_proxy_hdrs
+ unit_tests/test_HdrHeap.cc
+ unit_tests/test_Hdrs.cc
+ unit_tests/test_HdrUtils.cc
+ unit_tests/test_HdrHeap.cc
+ unit_tests/test_HeaderValidator.cc
+ unit_tests/test_Huffmancode.cc
+ unit_tests/test_mime.cc
+ unit_tests/test_URL.cc
+ unit_tests/unit_test_main.cc
+)
+target_link_libraries(test_proxy_hdrs PRIVATE ts::hdrs ts::tscore ts::inkevent
catch2::catch2)
+add_test(NAME test_proxy_hdrs COMMAND test_proxy_hdrs)
+
+add_executable(test_proxy_hdrs_xpack
+ XPACK.cc
+ HuffmanCodec.cc
+ unit_tests/test_XPACK.cc
+)
+target_include_directories(test_proxy_hdrs_xpack PRIVATE
${CMAKE_CURRENT_SOURCE_DIR})
+target_link_libraries(test_proxy_hdrs_xpack PRIVATE ts::tscore libswoc
catch2::catch2)
Review Comment:
Also depends on tscpputil. Doesn't depend on libswoc.
##########
iocore/eventsystem/CMakeLists.txt:
##########
@@ -49,7 +49,3 @@ target_link_libraries(inkevent
tscpputil # transitive
yaml-cpp::yaml-cpp # transitive
)
-
-if(TS_USE_HWLOC)
- target_link_libraries(inkevent PRIVATE hwloc::hwloc)
-endif()
Review Comment:
UnixEventProcessor.cc uses symbols from hwloc, so it is a usage requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
