JosiahWI commented on code in PR #10283:
URL: https://github.com/apache/trafficserver/pull/10283#discussion_r1309413743
##########
iocore/eventsystem/CMakeLists.txt:
##########
@@ -49,7 +49,3 @@ target_link_libraries(inkevent
tscpputil # transitive
yaml-cpp::yaml-cpp # transitive
)
-
-if(TS_USE_HWLOC)
- target_link_libraries(inkevent PRIVATE hwloc::hwloc)
-endif()
Review Comment:
If the hwloc related code is that tightly coupled, it probably shouldn't be
in 2 different components. If that's not the case, then imagine a scenario
where we no longer need the hwloc code in tscore. Eventsystem will fail to
compile, and the author will have to patch the inkevent CMakeLists as well,
requiring a change in 2 places instead of 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
