shinrich commented on code in PR #10308: URL: https://github.com/apache/trafficserver/pull/10308#discussion_r1330650436
########## doc/developer-guide/api/functions/TSHttpTxnTypeGet.en.rst: ########## @@ -0,0 +1,37 @@ +.. Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed + with this work for additional information regarding copyright + ownership. The ASF licenses this file to you under the Apache + License, Version 2.0 (the "License"); you may not use this file + except in compliance with the License. You may obtain a copy of + the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied. See the License for the specific language governing + permissions and limitations under the License. + +.. include:: ../../../common.defs + +.. default-domain:: c + +TSHttpTxnTypeGet Review Comment: Hmm. Guess I called it Txn, since I wanted to call this from a hook where I have a txn object. I want to distinguish between tunnel type (which is a connection characteristic) and a HTTP transaction (which I guess is a characteristic of the connection as well). However from an implementation perspective this is information we pull from the HttpSM. Let me think a bit on how invasive it would be to add this information to the vconn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
