maskit commented on code in PR #10308: URL: https://github.com/apache/trafficserver/pull/10308#discussion_r1336421565
########## doc/developer-guide/api/functions/TSHttpTxnTypeGet.en.rst: ########## @@ -0,0 +1,37 @@ +.. Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed + with this work for additional information regarding copyright + ownership. The ASF licenses this file to you under the Apache + License, Version 2.0 (the "License"); you may not use this file + except in compliance with the License. You may obtain a copy of + the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied. See the License for the specific language governing + permissions and limitations under the License. + +.. include:: ../../../common.defs + +.. default-domain:: c + +TSHttpTxnTypeGet Review Comment: Just to confirm, does that mean `TS_TXN_TYPE_HTTP` will be returned on a transaction that receives CONNECT method? I'm wondering if that is the expected and desired behavior. In other words, would you mind if somebody added `TS_TXN_TYPE_CONNECT_TUNNEL`? In either case, it would be nice to have the behavior documented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
