bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1376865198
##########
include/iocore/net/ConnectionTracker.h:
##########
@@ -71,23 +71,27 @@ class OutboundConnTrack
/// Per transaction configuration values.
struct TxnConfig {
- int max{0}; ///< Maximum concurrent connections.
- int min{0}; ///< Minimum keepalive connections.
- MatchType match{MATCH_IP}; ///< Match type.
+ int client_max{0}; ///< Maximum concurrent client
connections.
+ int server_max{0}; ///< Maximum concurrent server
connections.
+ int server_min{0}; ///< Minimum keepalive server
connections.
+ MatchType server_match{MATCH_IP}; ///< Server match type.
};
/** Static configuration values. */
struct GlobalConfig {
- std::chrono::seconds alert_delay{60}; ///< Alert delay in seconds.
+ std::chrono::seconds client_alert_delay{60}; ///< Alert delay in seconds.
+ std::chrono::seconds server_alert_delay{60}; ///< Alert delay in seconds.
};
// The names of the configuration values.
// Unfortunately these are not used in RecordsConfig.cc so that must be made
consistent by hand.
// Note: These need to be @c constexpr or there are static initialization
ordering risks.
- static constexpr std::string_view
CONFIG_VAR_MAX{"proxy.config.http.per_server.connection.max"};
- static constexpr std::string_view
CONFIG_VAR_MIN{"proxy.config.http.per_server.connection.min"};
- static constexpr std::string_view
CONFIG_VAR_MATCH{"proxy.config.http.per_server.connection.match"};
- static constexpr std::string_view
CONFIG_VAR_ALERT_DELAY{"proxy.config.http.per_server.connection.alert_delay"};
+ static constexpr std::string_view
CONFIG_CLIENT_VAR_MAX{"proxy.config.http.per_client.connection.max"};
+ static constexpr std::string_view
CONFIG_CLIENT_VAR_ALERT_DELAY{"proxy.config.http.per_client.connection.max"};
Review Comment:
True. :)
I should also add stats for the table size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
