serrislew commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1376892225
##########
src/iocore/net/UnixNetVConnection.cc:
##########
@@ -1449,6 +1453,28 @@ UnixNetVConnection::remove_from_active_queue()
}
}
+void
+UnixNetVConnection::enable_inbound_connection_tracking(ConnectionTracker::Group
*group)
+{
+ ink_assert(nullptr == conn_track_group);
+ conn_track_group = group;
+}
+
+void
+UnixNetVConnection::release_inbound_connection_tracking()
+{
+ // Update upstream connection tracking data if present.
+ if (conn_track_group) {
+ if (conn_track_group->_count >= 0) {
+ (conn_track_group->_count)--;
+ conn_track_group = nullptr;
Review Comment:
why does this need to be set to null? if so, why don't we set the group
object to null in accept functions when it hits `client_max` and we've hit
client throttling
##########
doc/admin-guide/files/records.yaml.en.rst:
##########
@@ -507,6 +507,13 @@ Network
between `proxy.config.net.max_connections_in` and
`proxy.config.net.max_requests_in`
is the amount of maximum idle (keepalive) connections |TS| will maintain.
+.. ts:cv:: CONFIG proxy.config.net.per_client.max_connections_in INT 0
+
+ The total number of client connections that |TS| will accept from a given
Review Comment:
total number of client concurrent connections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
