bryancall commented on code in PR #10627:
URL: https://github.com/apache/trafficserver/pull/10627#discussion_r1384001096
##########
include/proxy/http2/Http2CommonSession.h:
##########
@@ -169,6 +174,21 @@ class Http2CommonSession
int64_t read_from_early_data = 0;
bool cur_frame_from_early_data = false;
+ // Counter for received frames
+ std::atomic<uint64_t> _frame_counts_in[HTTP2_FRAME_TYPE_MAX + 1] = {
Review Comment:
Why do this need to be atomic? h2 connections shouldn't be handled on
multiple threads.
##########
include/proxy/http2/Http2CommonSession.h:
##########
@@ -169,6 +174,21 @@ class Http2CommonSession
int64_t read_from_early_data = 0;
bool cur_frame_from_early_data = false;
+ // Counter for received frames
+ std::atomic<uint64_t> _frame_counts_in[HTTP2_FRAME_TYPE_MAX + 1] = {
Review Comment:
Why doesd this need to be atomic? h2 connections shouldn't be handled on
multiple threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
