SolidWallOfCode commented on code in PR #10627: URL: https://github.com/apache/trafficserver/pull/10627#discussion_r1420935200
########## include/proxy/ProxySession.h: ########## @@ -111,6 +111,9 @@ class ProxySession : public VConnection, public PluginUserArgs<TS_USER_ARGS_SSN> virtual PoolableSession *get_server_session() const; + virtual uint64_t is_protocol_framed() const; Review Comment: Why does this return `uintr64_t` instead of `bool`, or alternatively why is it named "is_..." when that should indicate a boolean return? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
