bneradt commented on code in PR #10743:
URL: https://github.com/apache/trafficserver/pull/10743#discussion_r1385912988
##########
iocore/net/Connection.cc:
##########
@@ -229,7 +229,7 @@ Server::setup_fd_for_listen(bool non_blocking, const
NetProcessor::AcceptOptions
#endif
}
- if ((opt.sockopt_flags & NetVCOptions::SOCK_OPT_NO_DELAY) &&
+ if ((opt.sockopt_flags & NetVCOptions::SOCK_OPT_NO_DELAY) && !opt.f_mptcp &&
safe_setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, SOCKOPT_ON, sizeof(int)) <
0) {
goto Lerror;
}
Review Comment:
Can you help me understand this change? I assume TCP_NODELAY is not
applicable to MPTCP? Was it before, but not with the newer kernel
implementation? Or should these options never have been applied for MPTCP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
