serrislew commented on code in PR #10743:
URL: https://github.com/apache/trafficserver/pull/10743#discussion_r1386997698
##########
iocore/net/Connection.cc:
##########
@@ -229,7 +229,7 @@ Server::setup_fd_for_listen(bool non_blocking, const
NetProcessor::AcceptOptions
#endif
}
- if ((opt.sockopt_flags & NetVCOptions::SOCK_OPT_NO_DELAY) &&
+ if ((opt.sockopt_flags & NetVCOptions::SOCK_OPT_NO_DELAY) && !opt.f_mptcp &&
safe_setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, SOCKOPT_ON, sizeof(int)) <
0) {
goto Lerror;
}
Review Comment:
It seems like now that we are using MPTCP as a protocol and not a socket
option, the socket options for IPPROTO_TCP doesn't apply for sockets that are
not defined for IPPROTO_TCP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
