JosiahWI commented on code in PR #10759: URL: https://github.com/apache/trafficserver/pull/10759#discussion_r1388681949
########## cmake/FindLuaJIT.cmake: ########## @@ -15,35 +15,36 @@ # ####################### -# FindLuaJIT.cmake +# Findluajit.cmake # # This will define the following variables # -# LuaJIT_FOUND +# luajit_FOUND # # and the following imported targets # -# LuaJIT::LuaJIT +# luajit::luajit # -# LuaJIT exports their own config since LuaJIT-1.5.0, but it isn't -# present in the OpenSUSE libLuaJIT-devel-1.7.1 package and maybe others. Review Comment: I do not know where I got this information - it appears to be completely wrong. Might as well remove it entirely. ########## cmake/FindLuaJIT.cmake: ########## @@ -15,35 +15,36 @@ # ####################### -# FindLuaJIT.cmake +# Findluajit.cmake # # This will define the following variables # -# LuaJIT_FOUND +# luajit_FOUND # # and the following imported targets # -# LuaJIT::LuaJIT +# luajit::luajit # -# LuaJIT exports their own config since LuaJIT-1.5.0, but it isn't -# present in the OpenSUSE libLuaJIT-devel-1.7.1 package and maybe others. +# luajit exports their own config since luajit-1.5.0, but it isn't +# present in the OpenSUSE libluajit-devel-1.7.1 package and maybe others. find_package(PkgConfig REQUIRED) -pkg_check_modules(LuaJIT luajit) +pkg_check_modules(luajit luajit) include(FindPackageHandleStandardArgs) -find_package_handle_standard_args(LuaJIT - REQUIRED_VARS LuaJIT_LIBRARIES LuaJIT_INCLUDE_DIRS +find_package_handle_standard_args(luajit + REQUIRED_VARS luajit_INCLUDE_DIRS luajit_LINK_LIBRARIES luajit_LIBRARIES luajit_LIBRARY_DIRS + HANDLE_COMPONENTS Review Comment: Does the LuaJIT from PkgConfig use any components? ########## cmake/FindLuaJIT.cmake: ########## @@ -15,35 +15,36 @@ # ####################### -# FindLuaJIT.cmake +# Findluajit.cmake # # This will define the following variables # -# LuaJIT_FOUND +# luajit_FOUND # # and the following imported targets # -# LuaJIT::LuaJIT +# luajit::luajit # -# LuaJIT exports their own config since LuaJIT-1.5.0, but it isn't -# present in the OpenSUSE libLuaJIT-devel-1.7.1 package and maybe others. +# luajit exports their own config since luajit-1.5.0, but it isn't +# present in the OpenSUSE libluajit-devel-1.7.1 package and maybe others. find_package(PkgConfig REQUIRED) Review Comment: This can go in the root CMakeLists.txt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
