dragon512 commented on PR #10759: URL: https://github.com/apache/trafficserver/pull/10759#issuecomment-1808888119
> Please fix the case on the FindLuaJIT.cmake file (It should be Findluajit.cmake). Also, this adds a requirement of pkg-config being available on the system. We have not required pkg-config so far with cmake, so users that don't have that will have broken builds. I don't know if it was required for the autotools build. I think we could simplify finding reps if we also try png-config for other deps as well, so I'm fine adding it, but I think it should be included in the top cmakelists.txt file. > > If we make that optional, then we can optionally use pkg-config to try to find deps and reduce the need to provide _ROOT variables for non-standard dep locations. I fixed the case issues. I thought I had done it, but I must have messed up the git command. The original code had the pkg-config call. I only fixed up the code so that the pkg-config works as expected and to have it print out the message about what is found or not found for this library. now we have a ```-- Checking for module 'luajit' -- Package 'luajit', required by 'virtual:world', not found -- Could NOT find LuaJIT (missing: LuaJIT_LIBRARIES LuaJIT_INCLUDE_DIRS) ``` when not found and message of which library that is being used ( which was not reported before) ``` -- Checking for module 'luajit' -- Found luajit, version 2.1.0-beta3 -- Found luajit: /usr/include/luajit-2.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
