maskit commented on code in PR #10782:
URL: https://github.com/apache/trafficserver/pull/10782#discussion_r1396057903


##########
include/tscore/ink_platform.h:
##########
@@ -122,7 +122,7 @@ struct ifafilt;
 #ifdef HAVE_VALUES_H
 #include <values.h>
 #endif
-#ifdef HAVE_ALLOCA_H
+#if __has_include(<alloca.h>)

Review Comment:
   Looks like FreeBSD has `alloca()` in "stdlib.h", which is included above, 
and it doesn't have "alloca.h". Linux has `alloca()` in "alloca.h". So I 
suppose the intention is "If you build this on a system that has alloca.h you 
need it, but if you don't have it you are good".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to