phongn commented on code in PR #10782: URL: https://github.com/apache/trafficserver/pull/10782#discussion_r1396094205
########## include/tscore/ink_platform.h: ########## @@ -122,7 +122,7 @@ struct ifafilt; #ifdef HAVE_VALUES_H #include <values.h> #endif -#ifdef HAVE_ALLOCA_H +#if __has_include(<alloca.h>) Review Comment: I think in this case I would prefer to explicitly include `alloca.h` if available (which it is on recent macOS and Linux) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
