phongn commented on PR #10815: URL: https://github.com/apache/trafficserver/pull/10815#issuecomment-1830380045
> There is a check for `HAVE_STRUCT_TCP_INFO` on line 1296 in `plugins/header_rewrite/conditions.cc` that I think needs to be `HAVE_STRUCT_LINUX_TCP_INFO` Right now that block of code currently does a (¬FreeBSD ∨ glibc) check for the Linux-style `tcp_info`, and then devolves to the FreeBSD-style `tcp_info` by default. I've made this more explicit in the latest commit to using the CMake `HAVE_STRUCT_LINUX_TCP_INFO` define for the first case and adding a new `HAVE_STRUCT_FREEBSD_TCP_INFO` in the second case. In doing some research, there's also a macOS `tcp_connection_info` struct that behaves similarly but that is a future project to implement (and at any rate I am not aware of anyone using macOS in production, just for development). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
