phongn commented on PR #10815:
URL: https://github.com/apache/trafficserver/pull/10815#issuecomment-1830830255

   There are a few checks that look like this: 
   
   ```C
   #if defined(TCP_INFO) && defined(HAVE_STRUCT_TCP_INFO)
   ```
   
   Is this redundant? The existence of one should imply the other, unless 
someone is doing crazy things (and then we should have a redefinition 
preprocessor warning). If we are willing to accept preprocessor protection, we 
could remove the `HAVE_STRUCT_TCP_INFO` CMake build env. 
   
   cc: @dragon512  @cmcfarlen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to