SolidWallOfCode commented on code in PR #10627:
URL: https://github.com/apache/trafficserver/pull/10627#discussion_r1420948451
##########
src/proxy/http2/Http2ClientSession.cc:
##########
@@ -338,3 +338,19 @@ Http2ClientSession::get_version(HTTPHdr &hdr) const
{
return HTTP_2_0;
}
+
+uint64_t
+Http2ClientSession::is_protocol_framed() const
+{
+ return true;
+}
+
+uint64_t
+Http2ClientSession::get_received_frame_count(uint64_t type) const
+{
+ if (type == 999) { // TS_SSN_INFO_RECEIVED_FRAME_COUNT_H2_UNKNOWN in
apidefs.h.in
Review Comment:
Then why not use that value?
##########
src/proxy/http2/Http2ClientSession.cc:
##########
@@ -338,3 +338,19 @@ Http2ClientSession::get_version(HTTPHdr &hdr) const
{
return HTTP_2_0;
}
+
+uint64_t
+Http2ClientSession::is_protocol_framed() const
+{
+ return true;
+}
+
+uint64_t
+Http2ClientSession::get_received_frame_count(uint64_t type) const
+{
+ if (type == 999) { // TS_SSN_INFO_RECEIVED_FRAME_COUNT_H2_UNKNOWN in
apidefs.h.in
Review Comment:
Then why not use that definition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
