bneradt commented on code in PR #10996:
URL: https://github.com/apache/trafficserver/pull/10996#discussion_r1462558776
##########
src/proxy/http/HttpSessionManager.cc:
##########
@@ -491,6 +494,11 @@ HttpSessionManager::_acquire_session(sockaddr const *ip,
CryptoHash const &hostn
}
}
}
+
+ if (acquired) {
+ Metrics::Gauge::decrement(http_rsb.pooled_server_connections);
Review Comment:
Can you help me think through this? It seems like the decrement and
increment calls are reversed in this patch, but maybe I'm not thinking through
the logic correctly. Why do we decrement the stat when we acquire a session,
but increment when we release it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
