traeak commented on code in PR #10996:
URL: https://github.com/apache/trafficserver/pull/10996#discussion_r1462585285
##########
src/proxy/http/HttpSessionManager.cc:
##########
@@ -491,6 +494,11 @@ HttpSessionManager::_acquire_session(sockaddr const *ip,
CryptoHash const &hostn
}
}
}
+
+ if (acquired) {
+ Metrics::Gauge::decrement(http_rsb.pooled_server_connections);
Review Comment:
i agree the logic is confusing. The metric keeps track of the number of
sessions waiting in the pool.
* A transaction acquiring the session removes it from the session pool.
* A transaction releasing the session adds it to the session pool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
