brbzull0 commented on code in PR #11285:
URL: https://github.com/apache/trafficserver/pull/11285#discussion_r1576878864
##########
include/mgmt/rpc/jsonrpc/JsonRPCManager.h:
##########
@@ -244,8 +244,8 @@ class JsonRPCManager
InternalHandler(const RPCRegistryInfo *info, TSRPCHandlerOptions const
&opt) : _regInfo(info), _options(opt) {}
/// Sets the handler.
template <class T, class F> void set_callback(F &&t);
- explicit operator bool() const;
- bool operator!() const;
+ explicit operator bool() const;
+ bool operator!() const;
Review Comment:
methods too? this seems odd to me. I like this for members but for
methods is a bit weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
