bneradt commented on code in PR #11285:
URL: https://github.com/apache/trafficserver/pull/11285#discussion_r1578495055


##########
include/iocore/cache/AggregateWriteBuffer.h:
##########
@@ -88,19 +88,19 @@ class AggregateWriteBuffer
   void copy_from(char *dest, int offset, size_t nbytes) const;
 
   Queue<CacheVC, Continuation::Link_link> &get_pending_writers();
-  char *get_buffer();
-  int get_buffer_pos() const;
-  void add_buffer_pos(int size);
-  void seek(int offset);
-  void reset_buffer_pos();
-  int get_bytes_pending_aggregation() const;
-  void add_bytes_pending_aggregation(int size);
+  char                                    *get_buffer();
+  int                                      get_buffer_pos() const;
+  void                                     add_buffer_pos(int size);
+  void                                     seek(int offset);
+  void                                     reset_buffer_pos();
+  int                                      get_bytes_pending_aggregation() 
const;
+  void                                     add_bytes_pending_aggregation(int 
size);

Review Comment:
   Stuff like this can be helped with more concise type aliases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to