maskit commented on code in PR #11400:
URL: https://github.com/apache/trafficserver/pull/11400#discussion_r1625168357
##########
src/proxy/http3/Http3Frame.cc:
##########
@@ -280,10 +280,20 @@ Http3SettingsFrame::Http3SettingsFrame(const uint8_t
*buf, size_t buf_len, uint3
size_t id_len = QUICVariableInt::size(buf + len);
uint16_t id = QUICIntUtil::read_QUICVariableInt(buf + len, buf_len -
len);
len += id_len;
+ if (len > buf_len) {
Review Comment:
It should probably be `len >= buf_len`. Having only id is malformed, and
current code (even with your fix) can cause buffer-over-run on `size_t
value_len = QUICVariableInt::size(buf + len);`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
