shukitchan commented on code in PR #11400:
URL: https://github.com/apache/trafficserver/pull/11400#discussion_r1625455542
##########
src/proxy/http3/Http3Frame.cc:
##########
@@ -280,10 +280,20 @@ Http3SettingsFrame::Http3SettingsFrame(const uint8_t
*buf, size_t buf_len, uint3
size_t id_len = QUICVariableInt::size(buf + len);
uint16_t id = QUICIntUtil::read_QUICVariableInt(buf + len, buf_len -
len);
len += id_len;
+ if (len > buf_len) {
Review Comment:
Yes. I think even the reading is dangerous. I should give up before the
reading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
