maskit commented on code in PR #11590:
URL: https://github.com/apache/trafficserver/pull/11590#discussion_r1687150260
##########
plugins/experimental/url_sig/url_sig.cc:
##########
@@ -890,7 +890,6 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp, TSRemapRequestInfo
*rri)
if (*new_path) {
TSUrlPathSet(rri->requestBufp, rri->requestUrl, new_path,
strlen(new_path));
}
- TSUrlHttpParamsSet(rri->requestBufp, rri->requestUrl, nullptr, 0);
Review Comment:
I didn't follow the entire logic. It just doesn't look like equivalent even
if we set nullptr. If `new_path` contains parameters it may be fine, but what
if we don't set `new_path` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
