ezelkow1 commented on code in PR #11590:
URL: https://github.com/apache/trafficserver/pull/11590#discussion_r1687161813
##########
plugins/experimental/url_sig/url_sig.cc:
##########
@@ -890,7 +890,6 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp, TSRemapRequestInfo
*rri)
if (*new_path) {
TSUrlPathSet(rri->requestBufp, rri->requestUrl, new_path,
strlen(new_path));
}
- TSUrlHttpParamsSet(rri->requestBufp, rri->requestUrl, nullptr, 0);
Review Comment:
alright let me think about it some more. Pinged some around here but no one
really knows how this code was meant to work any more so its a bit of reverse
engineering going on. I believe that if we dont set new_path so it doesnt clean
up the path params, that it possibly would have been rejected anyway because
the plugin is going to parse the path params as things that are expected to be
signed (or elements of signing that it needs to interpret) and so it would
error out on them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
