ywkaras commented on code in PR #11613: URL: https://github.com/apache/trafficserver/pull/11613#discussion_r1691643628
########## include/iocore/eventsystem/IOBuffer.h: ########## @@ -1236,9 +1236,7 @@ class MIOBuffer const char *_location = nullptr; - MIOBuffer(void *b, int64_t bufsize, int64_t aWater_mark); - // cppcheck-suppress noExplicitConstructor; allow implicit conversion - MIOBuffer(int64_t default_size_index); Review Comment: I would have done it before if I had been aware of it. Implicit construction for UDTs rarely makes sense, it's generally confusing and error-prone. An example, if you were writing a `Complex` class, would be a `Complex(double real, double imaginary = 0.0)` constructor that was not marked explicit. But that's an unusual exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
