ywkaras commented on code in PR #11613:
URL: https://github.com/apache/trafficserver/pull/11613#discussion_r1691685664


##########
include/iocore/eventsystem/IOBuffer.h:
##########
@@ -1236,9 +1236,7 @@ class MIOBuffer
 
   const char *_location = nullptr;
 
-  MIOBuffer(void *b, int64_t bufsize, int64_t aWater_mark);
-  // cppcheck-suppress noExplicitConstructor; allow implicit conversion
-  MIOBuffer(int64_t default_size_index);

Review Comment:
   I would guess that code was written before the `explicit` keyword was 
available in whatever compiler they were using to build ATS at the time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to