moonchen opened a new pull request, #11984: URL: https://github.com/apache/trafficserver/pull/11984
For iocore source files and header files: * Make headers self-contained. Header files should work correctly regardless of the context of where it is included. This means the header should #include all of its dependencies. * Remove unused #includes Source and header files should only #include headers that are required. This reduces compile time, expresses clear ane explicit dependencies, reduces namespace pollution, enhances modularity, and decouples components. * Break up aggregate headers Some header files used to include a number of other header files for the sole purpose of packaging them into one #include directive. This increases compilation times, creates tight coupling and hidden dependencies, and introduces namespae pollution. Furthermore, this creates potential for circular dependencies. * Fix linter warnings Use C++ style casts. Pass by reference when appropriate. What this change is not: This does not get us all the way to "Include Only What You Use" (IWYU), although it is a step in that direction. This change does not address the issue of "private (P_*)" headers. This change only targets iocore. Changes to other files are mainly for the purpose of fixing compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
