moonchen commented on code in PR #11984: URL: https://github.com/apache/trafficserver/pull/11984#discussion_r1931120692
########## include/iocore/cache/HttpTransactCache.h: ########## @@ -30,8 +30,9 @@ ****************************************************************************/ #pragma once -#include "tscore/ink_platform.h" +#include "proxy/hdrs/HTTP.h" Review Comment: I agree that we should avoid including `proxy/` from `iocore/`, but as it stands today, HTTPHdr is dereferenced in HttpTransactCache.cc, for example, [here](https://github.com/moonchen/trafficserver/blob/b7b16275d210577b08d90db870570f718b9eecc7/src/iocore/cache/HttpTransactCache.cc#L200). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
