masaori335 commented on code in PR #12147:
URL: https://github.com/apache/trafficserver/pull/12147#discussion_r2049758893
##########
src/iocore/cache/CacheVC.h:
##########
@@ -281,8 +281,7 @@ struct CacheVC : public CacheVConnection {
int fragment;
int scan_msec_delay;
CacheVC *write_vc;
- char *hostname;
- int host_len;
+ std::string_view hostname;
Review Comment:
I remember we did back and forth around `pin_in_cache`. A change of `Doc`
obviously breaks compatibility, but the change in the CacheVC was not actually?
https://github.com/apache/trafficserver/commit/822172a339bc7fcbcabb6a9ebb2df4433b3bf8bc#diff-16cd59c47246f90109883f36526055d937b92630ed6e0cdba4664f2328bf1909L301-L303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
