masaori335 commented on code in PR #12147:
URL: https://github.com/apache/trafficserver/pull/12147#discussion_r2049756528
##########
src/iocore/cache/CacheVC.h:
##########
@@ -281,8 +281,7 @@ struct CacheVC : public CacheVConnection {
int fragment;
int scan_msec_delay;
CacheVC *write_vc;
- char *hostname;
- int host_len;
+ std::string_view hostname;
Review Comment:
If changing type of member of `CacheVC` breaks cache compatibility, I afraid
this change. Because the size are different. The underlaying types are `char *`
and `size_t`, I guess.
```
(lldb) p sizeof(char *)
(unsigned long) 8
(lldb) p sizeof(int)
(unsigned long) 4
(lldb) p sizeof(std::string_view)
(unsigned long) 16
```
Let me clarify the symptom, if cache compatibility is broken, we'll face
warnings when new ATS read old cache from disk, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
