zwoop commented on code in PR #12371:
URL: https://github.com/apache/trafficserver/pull/12371#discussion_r2219041562


##########
tests/gold_tests/pluginTest/header_rewrite/gold/cond-elif.gold:
##########
@@ -1,5 +1,5 @@
 ``
-> GET http://www.example.com/from_path/hrw-sets.png``
+> GET http://www.example.com/from_1/hrw-sets.png``

Review Comment:
   How would that be painful? I guess I don't really care what we name them, 
but they have to be named something :). I'd imagined that if you are adding a 
new test to an existing autest, you append to the current list of remap rules.  
Sequential numbering. There'd never be a reason to add a rule in the middle of 
remap rules I don't think.
   
   We could automate the numbering, but when I looked at that, it makes making 
the subsequent tests more difficult (you need some sort of identifier).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to