maskit commented on code in PR #12371: URL: https://github.com/apache/trafficserver/pull/12371#discussion_r2223038742
########## tests/gold_tests/pluginTest/header_rewrite/gold/cond-elif.gold: ########## @@ -1,5 +1,5 @@ `` -> GET http://www.example.com/from_path/hrw-sets.png`` +> GET http://www.example.com/from_1/hrw-sets.png`` Review Comment: > There'd never be a reason to add a rule in the middle of remap rules I don't think. If there is, at some point, just name it /from_x_y ? E.g. /from_4_1. I think similar test cases should be close each other. We could do "4_1", but that doesn't completely resolve the issue. Let's say we have "4_1", "4_2", and "4_3". If I wanted to insert a test between "4_1" and "4_2", I'd have to make "4_1_1" or renumber "4_2" and "4_3". Also even for the case that I append tests, somebody else could be appending another tests on the same file. Then the number would conflicts. Either of those have to update the test number. I don't think whether tests or remap rules matters in this discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
