bneradt opened a new pull request, #12453: URL: https://github.com/apache/trafficserver/pull/12453
This updates our Catch2 version from v2.13.8 to the latest v3.9.1. It also transitions us from the deprecated monolithic header file to the new library model using CMake via FetchContent. This has several advantages: * This uses the library model which the authors of Catch2 advocate for. The monolithic header we used before this patch is not "the primarily supported option". * Since not all of catch.hpp is built for every UT, compilation times are quicker. * Future updates of Catch2 becomes easier: simply update the GIT_TAG from the FetchContent invocation. * Since the new v3 version provides a main function definition via Catch2::Catch2WithMain, we no longer need the empty unit_test_main.cc files we had before. * The updated Catch v3 is purported to execute its checks more efficiently (according to the changelog). As a part of this transition, this removes src/records/unit_tests/unit_test_main_on_eventsystem.cc since that was added with #7704 for DynamicStats which has since been removed. In v2, this simply didn't run any tests. In v3, this failed because no tests were run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
