bneradt commented on code in PR #12453: URL: https://github.com/apache/trafficserver/pull/12453#discussion_r2274852225
########## lib/CMakeLists.txt: ########## @@ -19,6 +19,26 @@ add_compile_options(-Wno-shadow) set(BUILD_SHARED_LIBS 1) +if(BUILD_TESTING) + include(FetchContent) + fetchcontent_declare( + Catch2 + GIT_REPOSITORY https://github.com/catchorg/Catch2.git + GIT_TAG v3.9.1 + ) + fetchcontent_makeavailable(Catch2) + Review Comment: Thanks for the feedback @JosiahWI. To avoid fetching during builds I created a clone in lib/Catch2 like we have for lib/swoc, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
