bneradt commented on code in PR #12541:
URL: https://github.com/apache/trafficserver/pull/12541#discussion_r2407644002
##########
tests/gold_tests/tls/ssl_key_dialog.test.py:
##########
@@ -83,10 +84,19 @@
tr2reload.Processes.Default.Env = ts.Env
tr2reload.Processes.Default.ReturnCode = 0
+tr2reload = Test.AddTestRun("Await config reload")
+p = tr2reload.Processes.Default
+p.Command = 'echo awaiting config reload'
+p.Env = ts.Env
+p.ReturnCode = 0
+await_config_reload = tr.Processes.Process(f'config_reload_succeeded', 'sleep
30')
+await_config_reload.Ready = When.FileContains(ts.Disk.diags_log.Name,
"ssl_multicert.config finished loading", 2)
+p.StartBefore(await_config_reload)
+
Review Comment:
Without the TestRun to await the completion of the config reload, the config
reload wasn't actually taking effect. That's why this test is updated - it
should have been using `passphrase2` all along since that's the change made to
the multicert config above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
