bneradt commented on code in PR #12541:
URL: https://github.com/apache/trafficserver/pull/12541#discussion_r2407646104
##########
tests/gold_tests/traffic_ctl/traffic_ctl_server_output.test.py:
##########
@@ -28,27 +28,20 @@
Test.ContinueOnFail = True
-records_yaml = '''
- exec_thread:
- autoconfig:
- enabled: 0
- limit: 4
- '''
-
Test.Summary = 'Basic test for traffic_ctl server command features.'
-traffic_ctl = Make_traffic_ctl(Test, records_yaml)
+traffic_ctl = Make_traffic_ctl(Test)
######
# traffic_ctl server status
traffic_ctl.server().status().validate_with_text(
- '{"initialized_done": "true", "is_ssl_handshaking_stopped": "false",
"is_draining": "false", "is_event_system_shut_down": "false", "thread_groups":
[{"name": "ET_NET", "count": "4", "started": "true"}, {"name": "ET_TASK",
"count": "2", "started": "true"}, {"name": "ET_UDP", "count": "0", "started":
"false"}]}'
+ '{"initialized_done": "true", "is_ssl_handshaking_stopped": "false",
"is_draining": "false", "is_event_system_shut_down": "false", "thread_groups":
[{"name": "ET_NET", "count": "``", "started": "true"}, {"name": "ET_TASK",
"count": "2", "started": "true"}, {"name": "ET_UDP", "count": "0", "started":
"false"}]}'
Review Comment:
Not all machines are 4 core.
##########
tests/gold_tests/traffic_ctl/traffic_ctl_server_output.test.py:
##########
@@ -28,27 +28,20 @@
Test.ContinueOnFail = True
-records_yaml = '''
- exec_thread:
- autoconfig:
- enabled: 0
- limit: 4
- '''
-
Test.Summary = 'Basic test for traffic_ctl server command features.'
-traffic_ctl = Make_traffic_ctl(Test, records_yaml)
+traffic_ctl = Make_traffic_ctl(Test)
######
# traffic_ctl server status
traffic_ctl.server().status().validate_with_text(
- '{"initialized_done": "true", "is_ssl_handshaking_stopped": "false",
"is_draining": "false", "is_event_system_shut_down": "false", "thread_groups":
[{"name": "ET_NET", "count": "4", "started": "true"}, {"name": "ET_TASK",
"count": "2", "started": "true"}, {"name": "ET_UDP", "count": "0", "started":
"false"}]}'
+ '{"initialized_done": "true", "is_ssl_handshaking_stopped": "false",
"is_draining": "false", "is_event_system_shut_down": "false", "thread_groups":
[{"name": "ET_NET", "count": "``", "started": "true"}, {"name": "ET_TASK",
"count": "2", "started": "true"}, {"name": "ET_UDP", "count": "0", "started":
"false"}]}'
)
# Drain ats so we can check the output.
traffic_ctl.server().drain().exec()
# After the drain, server status should reflect this change.
traffic_ctl.server().status().validate_with_text(
- '{"initialized_done": "true", "is_ssl_handshaking_stopped": "false",
"is_draining": "true", "is_event_system_shut_down": "false", "thread_groups":
[{"name": "ET_NET", "count": "4", "started": "true"}, {"name": "ET_TASK",
"count": "2", "started": "true"}, {"name": "ET_UDP", "count": "0", "started":
"false"}]}'
+ '{"initialized_done": "true", "is_ssl_handshaking_stopped": "false",
"is_draining": "true", "is_event_system_shut_down": "false", "thread_groups":
[{"name": "ET_NET", "count": "``", "started": "true"}, {"name": "ET_TASK",
"count": "2", "started": "true"}, {"name": "ET_UDP", "count": "0", "started":
"false"}]}'
Review Comment:
Not all machines are 4 core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
