bneradt commented on code in PR #12544: URL: https://github.com/apache/trafficserver/pull/12544#discussion_r2427160564
########## plugins/compress/configuration.cc: ########## Review Comment: Sorry, @JakeChampion, I'm nickle and diming you with this PR. I keep noticing something after re-reviewing. Now that you're helpfully making this an enum class, we no longer need the `kParse` prefix since that qualification is redundant with the `ParserState` name. Can you please make these `Start`, `CompressibleContentType`, etc.? After this, I plan to give you a shipit. :) Thank you for your patience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
