bneradt commented on code in PR #12544:
URL: https://github.com/apache/trafficserver/pull/12544#discussion_r2408893158
##########
plugins/compress/configuration.cc:
##########
@@ -188,11 +188,7 @@ HostConfiguration::is_content_type_compressible(const char
*content_type, int co
return is_match;
}
-int
-isCommaOrSpace(int ch)
-{
- return (ch == ',') or isspace(ch);
-}
+constexpr auto isCommaOrSpace = [](int ch) -> int { return (ch == ',') ||
isspace(ch); };
Review Comment:
Is there an advantage to making this a lambda? Maybe just leave this as it
was, but make it a constexpr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
