bryancall commented on code in PR #12575:
URL: https://github.com/apache/trafficserver/pull/12575#discussion_r2449652420
##########
plugins/regex_remap/regex_remap.cc:
##########
@@ -45,17 +45,13 @@
#include "tscore/ink_time.h"
#include "tscore/ink_inet.h"
-#ifdef HAVE_PCRE_PCRE_H
-#include <pcre/pcre.h>
-#else
-#include <pcre.h>
-#endif
+#include "tsutil/Regex.h"
static const char *PLUGIN_NAME = "regex_remap";
// Constants
-static const int OVECCOUNT = 30; // We support $0 - $9 x2 ints, and this needs
to be 1.5x that
-static const int MAX_SUBS = 32; // No more than 32 substitution variables in
the subst string
+static const int MATCHCOUNT = 15;
Review Comment:
The match count was 10, is there a reason to increase it to 15?
##########
plugins/regex_remap/regex_remap.cc:
##########
@@ -370,36 +350,17 @@ RemapRegex::initialize(const std::string ®, const
std::string &sub, const std
// Compile and study the regular expression.
int
-RemapRegex::compile(const char *&error, int &erroffset)
+RemapRegex::compile(std::string &error, int &erroffset)
{
char *str;
- int ccount;
+ // int ccount;
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
