traeak commented on code in PR #12575: URL: https://github.com/apache/trafficserver/pull/12575#discussion_r2469746415
########## plugins/regex_remap/regex_remap.cc: ########## @@ -45,17 +45,13 @@ #include "tscore/ink_time.h" #include "tscore/ink_inet.h" -#ifdef HAVE_PCRE_PCRE_H -#include <pcre/pcre.h> -#else -#include <pcre.h> -#endif +#include "tsutil/Regex.h" static const char *PLUGIN_NAME = "regex_remap"; // Constants -static const int OVECCOUNT = 30; // We support $0 - $9 x2 ints, and this needs to be 1.5x that -static const int MAX_SUBS = 32; // No more than 32 substitution variables in the subst string +static const int MATCHCOUNT = 15; Review Comment: OVECCOUNT being 30 ends up with required MATCHCOUNT being 15. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
