Copilot commented on code in PR #12860:
URL: https://github.com/apache/trafficserver/pull/12860#discussion_r2770930119
##########
src/proxy/http/HttpSM.cc:
##########
@@ -7834,6 +7853,7 @@ HttpSM::update_stats()
milestones.difference_sec(TS_MILESTONE_SM_START,
TS_MILESTONE_DNS_LOOKUP_END),
milestones.difference_sec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_CONNECT),
milestones.difference_sec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_CONNECT_END),
+ milestones.difference_sec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_TLS_HANDSHAKE_END),
Review Comment:
The `server_tls_handshake` calculation is inconsistent with
`ua_tls_handshake`. The `ua_tls_handshake` field measures the duration of the
TLS handshake (END - START), but `server_tls_handshake` measures the time from
SM_START to handshake END. For consistency, `server_tls_handshake` should
measure the handshake duration like `ua_tls_handshake` does, using
`difference_sec(TS_MILESTONE_SERVER_TLS_HANDSHAKE_START,
TS_MILESTONE_SERVER_TLS_HANDSHAKE_END)` instead of
`difference_sec(TS_MILESTONE_SM_START, TS_MILESTONE_SERVER_TLS_HANDSHAKE_END)`.
```suggestion
milestones.difference_sec(TS_MILESTONE_SERVER_TLS_HANDSHAKE_START,
TS_MILESTONE_SERVER_TLS_HANDSHAKE_END),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
