cmcfarlen commented on code in PR #12860:
URL: https://github.com/apache/trafficserver/pull/12860#discussion_r2879070924
##########
src/iocore/net/SSLNetVConnection.cc:
##########
@@ -1579,6 +1579,12 @@ SSLNetVConnection::sslClientHandShakeEvent(int &err)
Metrics::Counter::increment(ssl_rsb.total_success_handshake_count_out);
sslHandshakeStatus = SSLHandshakeStatus::SSL_HANDSHAKE_DONE;
+
+ // Record TLS handshake end time for outbound connections
+ if (this->get_tls_handshake_begin_time()) {
+ this->_record_tls_handshake_end_time();
+ }
Review Comment:
Why was this added? This function seems to deal with the client side, but
the comment mentions outbound connections. And, if this were the outbound
side, are we expecting the metrics this function updates to include both sides
TLS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
